Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSRF protection #141

Closed
chriddyp opened this issue Oct 5, 2017 · 1 comment · Fixed by #146
Closed

Remove CSRF protection #141

chriddyp opened this issue Oct 5, 2017 · 1 comment · Fixed by #146

Comments

@chriddyp
Copy link
Member

chriddyp commented Oct 5, 2017

Besides the GET of index.html, Dash only supports POST requests with application/json. These are actually unsusceptible to CSRF attacks according to https://security.stackexchange.com/questions/23371/csrf-protection-with-custom-headers-and-without-validating-token/58308#58308. Based off of this, I believe that we should be able to remove CSRF protection and therefore will not require users to create a app.server.config.SECRET_KEY.

@ned2
Copy link
Contributor

ned2 commented Oct 14, 2017

I don't know enough about CSRF to comment on whether that makes sense, but if that's the case, then yeah I definitely reckon it should go. It caused me a lot of hassles working out that I needed to set the secret key, and it's something I've seen coming up a fair bit as an issue for people on the community forums. Would save a bit of headache potentially.

chriddyp added a commit that referenced this issue Oct 17, 2017
chriddyp added a commit that referenced this issue Oct 17, 2017
chriddyp added a commit that referenced this issue Oct 17, 2017
byronz pushed a commit that referenced this issue Apr 23, 2019
* revert dcc regression branch

* Update CHANGELOG.md
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this issue May 28, 2021
HammadTheOne pushed a commit that referenced this issue Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants