Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1014 - test for no_update by type rather than identity #1037

Merged
merged 4 commits into from
Dec 10, 2019
Merged

fix #1014 - test for no_update by type rather than identity #1037

merged 4 commits into from
Dec 10, 2019

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Dec 4, 2019 •
edited
Loading

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR
  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson mentioned this pull request Dec 4, 2019
Closed
8 tasks
Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alexcjohnson alexcjohnson merged commit e622f2a into dev Dec 10, 2019
@alexcjohnson alexcjohnson deleted the cached-no-update branch December 10, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Marc-Andre-Rivet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcjohnson @Marc-Andre-Rivet