Debug in same module #1288
Merged
Debug in same module #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannysepler
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
alexcjohnson
reviewed
Jun 1, 2020
|
Thanks @dannysepler - there's something wrong with our CI tests for everyone right now, but once we resolve that (and the little comment above) this looks good! |
Co-authored-by: alexcjohnson <johnson.alex.c@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1285. "pkgutil.find_loader" should return None on
__main__, but doesn't on many versions of python (and still might not? It's failing for me on 3.7).We should be able to just ignore
__main__for the hot reloader. I tried it on the file linked here https://community.plotly.com/t/debug-mode-breaks-when-subclassing-dash-core-component/38498 and it workedContributor Checklist
Tests still don't work for me locally. Hopefully the CI tests suffice.
optionals
CHANGELOG.md