-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pytest for testing extra (Fixes #1365) #1368
Conversation
@alexcjohnson Turns it out it isn't as simple as just upgrading pytest! Several tests now fail, all related to the following error message: /home/circleci/dash/venv/lib/python3.6/site-packages/pytest_sugar.py:214: PytestDeprecationWarning:
The TerminalReporter.writer attribute is deprecated, use TerminalReporter._tw instead at your own risk.
See https://docs.pytest.org/en/stable/deprecations.html#terminalreporter-writer for more information. pytest 6.0.0 changed the way they handle deprecations - they always call as errors now, as the affected features will be removed in 6.1.0. Seems pytest-sugar uses one of these affected features (https://docs.pytest.org/en/stable/changelog.html#id19 under Terminal Writer). I'll play with updating pytest-sugar locally, and see how that goes. If it's an issue on their end, I'll raise one there! |
That did it! The deprecation warning was fixed by updating pytest-sugar to 0.9.4. I also split pytest-mock into 2 requirements: 3.2.0 for python >= 3 and 2.0.0 for python == 2.7, which allows users to get the most up-to-date pytest -mock for their version. |
Fantastic! Nice job figuring out |
That should do it! Let me know if there's anything else - always happy to contribute :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! 💃
Update pytest and plugins to most recent version for testing extra.
Contributor Checklist
optionals
CHANGELOG.md