-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JSON encoding to use plotly.py JSON engine #1514
Conversation
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a changelog entry and this is great! 💃
There are also a couple instances of PlotlyJSONEncoder
in the tests, do you want to convert these too?
Oh actually I don't see |
Thanks! Yeah, I'll make sure both get used in some tests. |
Yeah, I added it to
I decided not to as a small extra check for backward compatibility. But it wouldn't take much to talk me into it 🙂 Changelog entry added in (53419b0) |
ping @alexcjohnson or @chriddyp. This is ready to merge, but I don't have permission to approve the percy diff mentioned above. Could one of you approve that in percy? |
Approved, looks good! |
Thanks! |
Update to make Dash use the active plotly.py JSON engine. The JSON engine system was introduced in plotly.py in plotly/plotly.py#2955.
Note: This PR adds a plotly.py lower version bound of 5.0.
plotly.py will use the faster orjson encoder by default if the orjson package is installed. But to make the orjson engine is in use, add this snippet: