[Bugfix] Handle missing timing_information gracefully
#1640
Conversation
…` functions has been registered to flask This test validates issue plotly#1624 The root of this issue lies in the devtools ui, and only occurs when the devtools ui has been enabled
In some situations the `timing_information` is not present in `flask.g`. E.g. when other functions have been registerd to the flask `before_request_funcs`. Dash should anticipate and handle gracefully. Fixes plotly#1624
remibaar
requested review from
alexcjohnson,
Marc-Andre-Rivet and
rpkyle
as code owners
remibaar
changed the title
timing_information gracefully
|
Percy check is failing because of a new string "This is a Copy/Paste friendly version of the traceback." But that's (probably) not due to the changes I've made |
There was a problem hiding this comment.
Thanks @remibaar - looks good, just a small simplifying suggestion. 💃
You're right that the Percy change has nothing to do with this PR - strange, we must have inherited a new version of Werkzeug or something? Not a big deal.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
|
Thanks @alexcjohnson for the simplification! That was exactly how I planned to code it, but for some reason didn't haha. Thanks for catching it. Do you also agree with the new integration test? I didn't exactly know where to put it, so I've putted in the |
|
The new test is excellent, thanks! I just added a changelog entry, will merge once tests pass. |
An error is raised when the devtools before request is not fully executed.
AttributeError: '_AppCtxGlobals' object has no attribute 'timing_information'I've created a test to replicate, and a fix to handle the error gracefully.
More info in #1624 and #1475
Contributor Checklist