Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More hljs langs #1729

Merged
merged 5 commits into from
Aug 26, 2021
Merged

More hljs langs #1729

merged 5 commits into from
Aug 26, 2021

Conversation

alexcjohnson
Copy link
Collaborator

With Dash coming to .NET and MATLAB, these should be included in our default highlightjs config: F#, C#, MATLAB.

I also took the opportunity to update pylint to v2.10. I started looking at this because for some reason pylint thinks multiprocess.Process isn't callable, and upgrading didn't fix that (surprised @jonmmease and others didn't hit this problem?) but it did introduce the disable-next syntax which is really nice for avoiding long lines and strange line breaks as pylint and black fight with each other.

A note: in #1679 we added the dash/dcc, dash/html, and dash/dash_table directories to .gitignore, but not until after their contents were committed. We should remove all of these files, and only commit them in master, but I'm not doing that here (and I'm committing the updated component bundles) so as not to further disrupt anyone else who depends on the dev branch here right now.

@@ -138,11 +138,11 @@ def validate_and_group_input_args(flat_args, arg_index_grouping):
func_kwargs = args_grouping
elif isinstance(arg_index_grouping, (tuple, list)):
func_args = list(args_grouping)
func_kwargs = dict()
func_kwargs = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@HammadTheOne HammadTheOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

LGTM. One failing test, but it runs fine locally, so probably just a flaky run.

@alexcjohnson alexcjohnson merged commit d21a365 into dev Aug 26, 2021
@alexcjohnson alexcjohnson deleted the more-hljs-langs branch August 26, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants