Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mini css extract plugin #1858

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Fix mini css extract plugin #1858

merged 4 commits into from
Dec 8, 2021

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Dec 8, 2021

Supersedes #1855

@ryanand26 I cherry-picked your commits onto dev instead of master, and the tests pass - not sure why that makes a difference, but that's what we want anyway. I'm going to make a few more minor updates since we're going to be rereleasing @plotly/webpack-dash-dynamic-import, then this will be ready to go. Thanks again!

Contributor Checklist

  • Update deps of @plotly/ npm packages
  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson merged commit 6cfb787 into dev Dec 8, 2021
@alexcjohnson alexcjohnson deleted the fix-mini-css-extract-plugin branch December 8, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants