Delete redundancy in pattern-matching callback resolution #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by a customer (including the proposed fix in this PR 🙇 ) PMCs bog down unreasonably when
ALLandMATCHare used together. Preliminary testing looks good, and unfortunately I don't see any obvious external symptoms to test - maybe just a large enough instance of this type of PMC that we know it would crash the browser without this patch?My suspicion is that part of the behavior being fixed here has been present since the beginning of PMCs, but I bet it was made worse when we refactored it and changed part to TypeScript.
CHANGELOG.md