Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graph animate frames #1915

Merged
merged 8 commits into from
Mar 9, 2022
Merged

Fix graph animate frames #1915

merged 8 commits into from
Mar 9, 2022

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Feb 10, 2022 •
edited
Loading

As described in issue #1474, when both dcc.Graph and go.Figure have animation, then, when the second animation in Figure is executed, the Frames from the first animation are played instead of the second one.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Fix graph frame update
    • Make test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@alexcjohnson
Copy link
Collaborator

Looks good! Please merge the latest dev and then add a changelog entry for this, then it'll be ready to go!

alexcjohnson
alexcjohnson approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Thanks!

@alexcjohnson alexcjohnson merged commit da43568 into plotly:dev Mar 9, 2022
@nickmelnikov82 nickmelnikov82 deleted the fix-graph-animate-frames branch March 10, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickmelnikov82 @alexcjohnson