-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pages
for multi-page app
#1947
Conversation
changelog
If a See commit 4bdf472 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is a fix for the bug reported in dash-labs plotly/dash-labs#85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice feature, I like it.
I think now that it's in dash directly instead of dash-labs, we can have better integration for the index rendering.
I am also wondering if there would be a way to do without a dcc.Location
and container to serve the proper page layout directly in _dash-layout
instead of an additional callback.
Co-authored-by: Eirik Lid <eiriklid@gmail.com>
@T4rk1n Thanks so much for your review! Can you say more about how we might do this:
|
In |
Co-authored-by: Alex Johnson <alex@plot.ly>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Love it! This has been an epic effort @AnnMarieW, can't wait to get it into everyone's hands!
This PR moves the
pages
plug-in from dash-labs to dash.Until the tests are written, the app in the
usage
folder can be used to try the new features.To Do
dash.register_page
. See dash-labs #76. Status: Deferred for now, see comments in dash-labs issue.pages
function only when those features are being used.usage
folderCHANGELOG.md
Test coverage
Find a live demo of the
pages
features at https://dashlabs.pythonanywhere.com/