-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated flask shutdown with thread kill. #1963
Conversation
f1aa3ce
to
1f8fac9
Compare
@T4rk1n this works great, and on CI it looks perfect. However when I run tests locally (mac) I see warnings with every test case. Can we find a way to get rid of these, so the test output is clean? Might be as simple as putting the
|
@alexcjohnson I wrapped the |
68c26f9
to
842cdc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That did it - nice work! 💃
842cdc5
to
a3bbd74
Compare
Replace usage of deprecated flask shutdown by a thread kill.
Resolve #1780
Contributor Checklist
CHANGELOG.md