Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary recalculation of dates #1976

Merged
merged 4 commits into from
Apr 19, 2022
Merged

Removed unnecessary recalculation of dates #1976

merged 4 commits into from
Apr 19, 2022

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Mar 17, 2022 •
edited
Loading

As described in issue #1962 DatePickerSingle and DatePickerRange are extremely slow when provided a long list of disabled_days.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • fix is_outside_range function
    • make test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

T4rk1n
T4rk1n reviewed Apr 4, 2022
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the test before rebuilding with the fix and it froze for over 15 seconds before I closed the browser. With the fix it passed almost instantly.

💃 After merging dev and adding a changelog entry.

components/dash-core-components/src/fragments/DatePickerSingle.react.js Show resolved Hide resolved
@alexcjohnson alexcjohnson merged commit 4b03e5a into plotly:dev Apr 19, 2022
@nickmelnikov82 nickmelnikov82 deleted the fix-is-outside-range-function branch April 20, 2022 07:17
@T4rk1n T4rk1n mentioned this pull request Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickmelnikov82 @alexcjohnson @T4rk1n