Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty headerOpEdges. #2015

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

nickmelnikov82
Copy link
Member

As described in issue #1854 DataTable with row_selectable="single or multi" and filter_action="native" seems to cause the JS error.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • fix issue
    • add test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickmelnikov82 💃

@alexcjohnson alexcjohnson merged commit 5ca0339 into plotly:dev Apr 19, 2022
@nickmelnikov82 nickmelnikov82 deleted the fix-factory-empty-props branch April 20, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants