-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dcc.Markdown prop 'link_target' #2034
Conversation
Beautiful, with a test and everything 😍 |
Great! Just added the changelog. |
The Percy tests here are showing a problem (Python errors showing up in the browser as a raw string rather than rendered HTML) that I suspect is due to the latest Werkzeug release. It certainly isn't anything you did in this PR @adrianoesch, but I don't want to merge until we fix it so we don't lose the correct Percy baselines. @T4rk1n can you take a look at addressing this? |
@alexcjohnson The doctype changed to all lowercase in werkzeug 2.1.2, I modified the check to accommodate all case in #2035 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
This PR is adding the prop
link_target
to dcc.Markdown component, analogous to the behaviour in datatable and thereby closing #1827.Contributor Checklist
optionals
CHANGELOG.md