Fixed viewport meta-tags #2084
Merged
Fixed viewport meta-tags #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Jun 9, 2022
| # -3 for the meta charset, http-equiv and viewport. | ||
| assert len(meta) == 3, "Should have 3 meta tags" | ||
|
|
||
| viewport_meta = meta[2] |
There was a problem hiding this comment.
Better not to depend on the order of the returned meta elements. Also if we add more default meta tags in the future this test would need to change. Instead, find just the viewport tags and ensure there's exactly one:
meta = dash_duo.find_elements('meta[name="viewport"]')
alexcjohnson
reviewed
Jun 9, 2022
| @@ -133,6 +133,29 @@ def test_inin007_meta_tags(dash_duo): | |||
| assert meta_tag.get_attribute("content") == meta_info["content"] | |||
|
|
|||
|
|
|||
| def test_inin007b_change_viewport_meta_tag(dash_duo): | |||
There was a problem hiding this comment.
I'd rather we not squeeze test numbers in between with b or such - makes it harder to run just one test with eg pytest -k inin007. Just shift some of the other test numbers so this one can have its own. Maybe the ones up front since this file starts at inin004?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dash 2.5.0, a default viewport meta tag was added as recommended for mobile-optimized sites by mdn.
This PR makes it so that this feature can be disabled by providing an empty viewport meta tag.
e.g.
app = Dash(meta_tags=[{"name": "viewport"}])Contributor Checklist
CHANGELOG.md