Dropdown component label search #2110
Conversation
T4rk1n
changed the title
| let labelKey = 'label'; | ||
| if (firstOption && firstOption.search) { | ||
| labelKey = 'search'; | ||
| } else if (firstOption && React.isValidElement(firstOption.label)) { |
There was a problem hiding this comment.
I can see people using strings for some options and components for others - like if they want a few options to have custom font color but others just use the default behavior. So just looking at the first one may not be robust. Also wondering if there's a way to pull the text out of a component for the same use case, particularly when the value is encoded in a way that isn't useful for searching (matching names to ID numbers or something). But it could still be nice to search on value too, especially if the search would match EITHER label or value. Is that possible?
There was a problem hiding this comment.
But it could still be nice to search on value too, especially if the search would match EITHER label or value. Is that possible?
It's possible to add field indexes to the search, maybe we should add a new prop search_indexes, then it could match any field in a dictionary of options ?
T4rk1n
changed the title
T4rk1n
force-pushed
the
dropdown-cap-search
branch
from
1505f55 to
a3e393d
Compare
Add
searchprop for the options ofdcc.Dropdown. Fix #2108labelis a component or provide a custom search value different from the label.valuewill be used for search.