Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add encoding to file open calls. #2131

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Add encoding to file open calls. #2131

merged 2 commits into from
Jul 13, 2022

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Jul 13, 2022

alexcjohnson
alexcjohnson approved these changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Ha, there were a lot of them left. Thanks!

@alexcjohnson
Copy link
Collaborator

Just needs a changelog entry :)

@T4rk1n T4rk1n merged commit 2a6bc98 into dev Jul 13, 2022
@T4rk1n T4rk1n deleted the open-encoding branch July 13, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Custom components error during build - char encoding
2 participants
@T4rk1n @alexcjohnson