-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1519 callbacks waiting fix #2344
Conversation
@alexcjohnson rebasing #1627, took way longer than expected, so I simply created a new branch. This is way cleaner and easier to test. Marc-Andres comment is pretty much what I am doing to fix the issue, in that I traverse the entire tree and filter out duplicate calls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Thanks @eff-kay, looks good to me! I refactored your test a little, to sequence based on a Lock
rather than delays and to look at number of callback invocations to ensure we aren't missing an intermediate state - but I'm pretty sure it still tests the same behavior.
@alexcjohnson I verified the test, it validates the correct thing. I have one small comment on understanding how locks work, other than that feel free to merge the PR. |
Fixes #1519
the description of what this PR does is found in this comment
#1627 (comment)
Contributor Checklist
optionals
CHANGELOG.md