Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 logo as favicon #2367

Merged
merged 2 commits into from
Dec 17, 2022
Merged

2022 logo as favicon #2367

merged 2 commits into from
Dec 17, 2022

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Dec 17, 2022

Updating to our current logo. I kept just it as a single favicon.ico file.

There are tons of more complicated things we could do if we wanted to optimize this... our main site plotly.com seems to serve a different file for every browser (on my mac I mostly get .avif or .webp), plus it looks for dark/light mode in the OS. One very simple thing we could do is switch to a .png now that we don't support IE, but that's a bigger project and all we'd really stand to gain is a reduction in file size (this favicon.ico is 15kb, a good favicon.png can be ~1-2kb - we have bigger file size issues than a little 10kb savings!) or better looks in some edge cases where this image gets used at a higher resolution (these don't seem very common, things like making a webpage look like an app on iOS or Android)

  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson merged commit c60703e into dev Dec 17, 2022
@alexcjohnson alexcjohnson deleted the favicon-2022 branch December 17, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant