Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback id to long callback key generation. #2473

Merged
merged 6 commits into from
Mar 29, 2023
Merged

Add callback id to long callback key generation. #2473

merged 6 commits into from
Mar 29, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 21, 2023

Fix #2221

chriddyp
chriddyp approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@chriddyp chriddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃🏼 once a test is added

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Mar 28, 2023

Seems like there is some issue with the celery test, not sure if the solution here is enough for celery or if it's the test that is flawed, only one function is kept for both outputs in the worker and it's also random which one is choosen.

@T4rk1n T4rk1n merged commit 6773440 into dev Mar 29, 2023
@T4rk1n T4rk1n deleted the fix-2221 branch March 29, 2023 14:39
@etpinard etpinard mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriddyp chriddyp chriddyp approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Background callbacks with different outputs not working
2 participants
@T4rk1n @chriddyp