Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove event listeners for Location on unmount #2489

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Remove event listeners for Location on unmount #2489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43debc1
Remove event listeners for Location on unmount
jowlo Mar 31, 2023
eda1a31
Update Changelog
jowlo Mar 31, 2023
55a5735
Merge branch 'dev' into fix/remove-location-listeners-on-unmount
T4rk1n Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## Fixed

- [#2489](https://github.com/plotly/dash/pull/2489) Fix location change event handling when `Location` objects are removed from the layout. Event handlers would not be removed and eventually change props of a random DOM element, fix [#1346](https://github.com/plotly/dash/issues/1346)
- [#2498](https://github.com/plotly/dash/pull/2498) Fix error when caching callbacks which return `Patch` objects by making `Patch` objects picklable
- [#2491](https://github.com/plotly/dash/pull/2491) Fix clientside inline function name not found, fix [#2488](https://github.com/plotly/dash/issues/2488)

Expand Down
8 changes: 8 additions & 0 deletions components/dash-core-components/src/components/Location.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ export default class Location extends Component {
this.updateLocation(this.props);
}

componentWillUnmount() {
window.onpopstate = () => {};
window.removeEventListener(
'_dashprivate_pushstate',
this.onLocationChange
);
}

UNSAFE_componentWillReceiveProps(nextProps) {
this.updateLocation(nextProps);
}
Expand Down