-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge JupyterDash with Dash #2530
Conversation
Exciting work! Thanks @T4rk1n, looking forward to using this. |
@@ -0,0 +1,48 @@ | |||
{ | |||
"name": "@plotly/dash-jupyterlab", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently published to npm as jupyterlab-dash - is that published version used for anything? Is there a reason to change its name and scoping here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses the tar bundle included in the Python package, that needs to be built the first time you open jupyterlab. Not sure if the npm package is used for anything, the jupyterlab docs says it can be directly to jupyterlab with npm but I am not sure the user really want to do that. https://jupyterlab.readthedocs.io/en/latest/extension/extension_tutorial.html#publishing-your-extension
I changed the name to avoid conflict if jupyter-dash is installed.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
@@ -39,5 +39,17 @@ | |||
page_container, | |||
) | |||
from ._patch import Patch # noqa: F401,E402 | |||
from ._jupyter import jupyter_dash # noqa: F401,E402 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this in the main namespace? Will users ever need to use it directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved some options previously in JupyterDash .__init__
or run
to be globally settable on the jupyter_dash
instance.
You can change the default mode with jupyter_dash.default_mode
and disable exception inlining jupyter_dash.inline_exceptions = False
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @LiamConnors to make sure these options get documented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 just a style point #2530 (comment), this looks great!
Is an additional extension required to be able to open dash as a jupyterlab-tab? On a clean setup, I'm trying https://dash.plotly.com/dash-in-jupyter#display-modes I'm uncertain whether to open an issue for my concern. |
hi @MP-MaximilianLattka |
As @MP-MaximilianLattka mentions above, I'm also having similar issues with I've simply been attempting to get the minimal dash app to work in this mode, but sadly to no avail. I've pinned back Can you recommend a combination other than Many thanks P.S., Are there other similar live issues that you know of that I can track to monitor progress on this? |
This might be a bug.
|
@Coding-with-Adam Also, you'll notice that once you start the app, no jupyter tab is opened, but you can hit the URL of the app in another browser window and it connects and renders. |
Merge JupyterDash functionality in dash to render dash apps in jupyter notebooks.
Simply run app inside a jupyter cell to render automatically on the cell output:
Changed from jupyter dash
inline
.tab
, automatically open the app in a new browser tab.