Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: scope CSS of input elements #2589

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Bugfix: scope CSS of input elements #2589

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd6ed5b
Add class to Input elements so that CSS rules can be scoped
KoolADE85 Jul 6, 2023
745f0f3
Small changes to address code review feedback
KoolADE85 Jul 7, 2023
aa85b3c
Ensure no trailing space is added to className
KoolADE85 Jul 10, 2023
494e23d
Update CHANGELOG
KoolADE85 Jul 10, 2023
3e6b531
Exclude search element from html checks for now
KoolADE85 Jul 12, 2023
1623592
Remove duplicate key
KoolADE85 Jul 12, 2023
53bdf71
Revert "Exclude search element from html checks for now"
KoolADE85 Jul 12, 2023
b156dc4
build
KoolADE85 Jul 12, 2023
c4ca03b
Merge branch 'dev' into bugfix/dash-embedded-83
KoolADE85 Jul 12, 2023
11af805
build
KoolADE85 Jul 12, 2023
ffcc9eb
build
KoolADE85 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/).

## UNRELEASED

## Fixed

- [dash-embedded-component #83](https://github.com/plotly/dash-embedded-component/issues/83) CSS for input elements not scoped to Dash application
T4rk1n marked this conversation as resolved.
Show resolved Hide resolved

## [2.11.1] - 2023-06-29

## Fixed
Expand Down
2 changes: 2 additions & 0 deletions components/dash-core-components/src/components/Input.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,15 @@ export default class Input extends PureComponent {
data-dash-is-loading={
(loading_state && loading_state.is_loading) || undefined
}
className={['dash-input', this.props.className].join(' ')}
T4rk1n marked this conversation as resolved.
Show resolved Hide resolved
ref={this.input}
onBlur={this.onBlur}
onChange={this.onChange}
onKeyPress={this.onKeyPress}
{...valprops}
{...omit(
[
'className',
Comment on lines 87 to +89
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we use this a lot but I'd love to get rid of this ...omit pattern pretty much wherever we use it. It causes various problems, like I bet we're currently improperly forwarding persistence/persistence_type/persisted_props here, and some other places we still forward loading_state so the DOM ends up with `loading_state="[object Object]". Instead we should figure out which props we DO want and pick them, or just individually forward them. I thought I had made an issue for this but not seeing it now 🤔

'debounce',
'value',
'n_blur',
Expand Down
6 changes: 3 additions & 3 deletions components/dash-core-components/src/components/css/input.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
input:invalid {
input.dash-input:invalid {
outline: solid red;
}

input:valid {
input.dash-input:valid {
outline: none black;
}
}
31 changes: 31 additions & 0 deletions components/dash-core-components/tests/integration/input/test_input_basics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,34 @@ def test_inbs002_user_class(dash_dcc):
dash_dcc.wait_for_style_to_equal(".test-input-css input", "width", "420px")

assert dash_dcc.get_logs() == []


def test_inbs003_styles_are_scoped(dash_dcc):
app = Dash(__name__)

app.index_string = """
<html>
<body>
<input id="ExternalInput" required />
{%app_entry%}
{%config%}
{%scripts%}
{%renderer%}
</body>
</html>
"""

app.layout = html.Div(
className="test-input-css",
children=[dcc.Input(id="DashInput", required=True, className="unittest")],
)

dash_dcc.start_server(app)

external_input = dash_dcc.find_element("#ExternalInput")
dash_input = dash_dcc.find_element(".unittest")

external_outline_css = external_input.value_of_css_property("outline")
dash_outline_css = dash_input.value_of_css_property("outline")

assert external_outline_css != dash_outline_css