Feature: dcc.Input accepts a number for its debounce argument #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
reviewed
Jul 10, 2023
| this.setInputValue = this.setInputValue.bind(this); | ||
| this.setPropValue = this.setPropValue.bind(this); | ||
| } | ||
|
|
||
| UNSAFE_componentWillReceiveProps(nextProps) { | ||
| const {value} = this.input.current; | ||
| if (this.state?.pendingEvent) { |
There was a problem hiding this comment.
State should be defined in constructor.
There was a problem hiding this comment.
Good call. Changed in 0198e20
T4rk1n
reviewed
Jul 10, 2023
T4rk1n
reviewed
Jul 10, 2023
components/dash-core-components/tests/integration/input/test_debounce.py
Outdated
Show resolved
Hide resolved
|
LGTM, just a couple of minor nonblocking comments, but we do still need a changelog entry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes dcc.Input so that it accepts a "number of seconds" for the debounce argument.
When passing a number, the callbacks to the Dash server are debounced accordingly.
This does not change the behaviour of a boolean debounce argument.
With this PR in place, we will be able to address this issue in the dbe project.
Contributor Checklist
optionals
CHANGELOG.md