-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Flask & Werkzeug in requires-install.txt #2614
Conversation
Thanks @gothicVI - Flask 2.3 is ok with most of the dash ecosystem but there are some packages (including some on our enterprise side that unfortunately are not visible open-source) that we still need to update before we'll be ready to allow Flask 2.3. Thank you for your patience! |
@alexcjohnson could you point out which open source packages are not currently compatible? Maybe we could open a PR for them. For the non-open source ones, wouldn't it be possible to limit the flask version on your side? The current requirements are quite open ( |
I'd opt for removing the upper version limit entirely: |
That’s what we used to do, see #2538 for context on why we added an upper bound
I’m not sure. The open-source ones maintained by Plotly are good AFAIK, but I would look at 3rd-party packages that alter the back end.
Plausible, assuming we can identify ahead of time where the potential issues are. |
Which from my point of view is the wrong approach. That should be dealt with by the user using |
I linked to exactly that article in #2538 and explained why we feel our decision is consistent with it. It’s not every package. It’s just Flask, which has consistently broken something in Dash with every minor update. Thus an upper bound here is just a statement that we expect this to be true in the future as well. No other package has such a history, hence we don’t specify any other upper bounds. I’m sorry that it is taking us a while to find and fix the other Flask 2.3 issues but we feel strongly that this is better than uncontrolled breakage. |
superseded by #2674 |
Fixes #2592
optionals
CHANGELOG.md