Remove ansi2html. #2721
Remove ansi2html. #2721
Conversation
dash/_jupyter.py
Outdated
| html_str = re.sub("background-color:[^;]+;", "", html_str) | ||
|
|
||
| return html_str, 500 | ||
| return ansi_stacktrace, 500 |
There was a problem hiding this comment.
So the comment above:
# Use IPython traceback formatting to build colored ANSI traceback
# string
Is no longer true for some reason? Does worry me a little that maybe in some cases the color will creep in and lead to ugly junk in the output. I wonder if instead of FormattedTB we could use something simpler like traceback.format_exception?
There was a problem hiding this comment.
My bad, I didn't see the color, without dev_tools_prune_errors=False I only had one line and the color was dark red, in the devtools error had the escaped ansi symbols.
There is a NoColor mode that should do.
| @@ -7,7 +7,7 @@ flake8==3.9.2 | |||
| flaky==3.7.0 | |||
| flask-talisman==1.0.0 | |||
| isort==4.3.21;python_version<"3.7" | |||
| mimesis | |||
| mimesis<=11.1.0 | |||
There was a problem hiding this comment.
NBD since this is only in requires-ci, but why is this lock needed?
There was a problem hiding this comment.
The latest version introduced a union type like str | int and that is only supported in recent python versions.
There was a problem hiding this comment.
OK yeah weird:
To work with Mimesis on Python versions 3.8 and 3.9, the final compatible version is Mimesis 11.1.0. Install this specific version to ensure compatibility.
but even v12.1.0 says
Requires: Python >=3.8, <4.0
Wonder why they didn't just bake that first statement into the python_requires 🤔
Resolve #2713 by removing the ansi2html package, upon investigation the stacktrace weren't colored anyway.