-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure ci for python 3.10 #2734
Conversation
ccde9e8
to
78de5bb
Compare
So CI passed on 3.10 for everything except "Display npm errors and exit on failed builds". Locally running "npm ci" always writes logs so I don't see how to make this step pass |
since npm/cli@6734ba3 (npm v8.2) npm will always write debug logs |
since npm 8.2 logs are alway written, so this step will always fail
Let's take the Python version number off of the Percy snapshots - no reason they should all look brand new just because we changed that, and we've long since stopped taking snapshots on multiple Python versions. That's here: Line 162 in 6a8da52
|
Good to know! These still may be useful for debugging when tests DO fail - so perhaps we can either keep the |
|
||
# py3.9 hardcoded here to keep snapshot names the same accorss | ||
# future python upgrades | ||
snapshot_name = f"{name} - py3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's a good strategy - this means we know what changes if any the rest of the changes in this PR cause in the percy snapshots. After merging we can make another PR to remove the version number entirely, which will cause all the snapshots to look new but we can blindly approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Great work, thanks!
Fixes #1863
switch 3.9 CI to 3.10 CI
Contributor Checklist
optionals
CHANGELOG.md