Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic loading: map namespace to package name in case they differ. #2771

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Dynamic loading: map namespace to package name in case they differ. #2771

merged 3 commits into from
Mar 1, 2024

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Mar 1, 2024

Fix cases where the namespace of a component package differ from it's import module.

@T4rk1n T4rk1n requested a review from alexcjohnson as a code owner March 1, 2024 14:54
alexcjohnson
alexcjohnson approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great, can you just update one of the test component packages so it makes use of this?

@T4rk1n T4rk1n merged commit e580ff0 into dev Mar 1, 2024
3 checks passed
@T4rk1n T4rk1n deleted the fix/namespace-package-map branch March 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T4rk1n @alexcjohnson