Fixes for dynamic loading. #2780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
T4rk1n
commented
Mar 4, 2024
T4rk1n
commented
- Fix [BUG] Weird component redraw issue in dash 2.16 #2775, additional redraws.
- Fix [BUG] dash_mantine_components can't be found in dash 2.16.0 #2778, dynamic loading and pages.
|
FYI - I tried this fix with the example in #2781, but it didn't works, so it's probably a different issue. |
alexcjohnson
reviewed
Mar 5, 2024
| @@ -15,16 +14,6 @@ type LibraryComponentProps = { | |||
|
|
|||
| const LibraryComponent = (props: LibraryComponentProps) => { | |||
| const {props_check, namespace, type, ...rest} = props; | |||
|
|
|||
| const context = useContext(LibrariesContext); | |||
There was a problem hiding this comment.
So I guess this was left over from a previous iteration but not needed the way you finally implemented the feature?
alexcjohnson
reviewed
Mar 5, 2024
| }; | ||
| crawlLayout(layout, addLib); | ||
| if (validation_layout) { | ||
| crawlLayout(validation_layout, addLib); |
There was a problem hiding this comment.
Doesn't this defeat the purpose though? The difference between validation_layout and layout is just items that we're not going to show on the initial view.
|
Can be closed but I'll add the redraw test later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.