Fix: None in "wait" Methods Causing Incorrectly Passing Tests
#2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing due to bad test that is fixed in #2816. Once that PR is merged and this merged into this PR, the tests will all pass. |
emilykl
reviewed
Apr 15, 2024
| with pytest.raises(TimeoutException) as err: | ||
| dash_duo.wait_for_contains_text("#content", "None", timeout=1.0) | ||
|
|
||
| assert ( |
emilykl
reviewed
Apr 15, 2024
| with pytest.raises(TimeoutException) as err: | ||
| dash_duo.wait_for_contains_text("#value-item", "None", timeout=1.0) | ||
|
|
||
| assert ( |
emilykl
reviewed
Apr 15, 2024
|
I like this solution. Need to think through possible consequences though as this is technically a breaking change in Dash Testing. |
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
emilykl
reviewed
Apr 17, 2024
emilykl
reviewed
Apr 17, 2024
emilykl
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Looks good to me @TillerBurr -- thanks for the contribution! ✨
There's some failing tests I want to investigate but I'm pretty sure they're not related to your changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2818. This is my take on solving the issue. This method ignores the value prop if it is
None. I think there is merit to adding await_for_value_to_equal, but this solves the immediate problem, while causing as little friction as possible.As mentioned in #2818, there are also potential issues in the other methods in the
dash.testing.waitnamespace. Not sure if those cases need to be handled here.Contributor Checklist
Noneisn't cast to a string.optionals
CHANGELOG.md