Fix dcc.Loading spinner style #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
reviewed
May 14, 2024
|
@T4rk1n - Thanks for your speedy review! Yeah, I need to fix the tests too. But I upgraded chrome, and can't run tests locally anymore. Need to figure out how to update the chrome driver - I can't find a version for Linux and Chrome 124. |
I had the same issue with chrome update, I ended up uninstalling chrome from the ubuntu store and downloaded both chrome and the chromedriver from this page: https://googlechromelabs.github.io/chrome-for-testing/#stable |
|
@T4rk1n This is ready now 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2858
Applies
overlay_styleprop to thedcc.Loadingchildrenonly and not to the spinner component.