-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate LogoutButton #2899
Merged
Merged
Deprecate LogoutButton #2899
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1b3f328
Outputs DeprecationWarning if LogoutButton is used in layout
leeagustin d6e1b58
Modifies test to check if LogoutButton use outputs DeprecationWarning
leeagustin c54ae91
Modifies test to show that DeprecationWarning is being output when Lo…
leeagustin 87385a9
Refactors deprecated_types to deprecated_components
leeagustin 3b0ab61
Merge branch 'dev' into deprecate-LogoutButton
T4rk1n 6bd822e
Merge branch 'deprecation' into deprecate-LogoutButton
T4rk1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add a condition
if add_initial_logout_button
for testing the deprecation notice otherwise it fails. Maybe better to just test the deprecation notice in a new test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. My worry is that
DeprecationWarning
is not being output when theLogoutButton
is being used inside a callback—only when theLogoutButton
is defined inapp.layout
.This is the reason I was checking for the warning in the two separate scenarios. However, if we don't need to output a
DeprecationWarning
when theLogoutButton
is used inside a callback, then I can just create a new test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leeagustin can you please let us know if you added or are interested in adding the new test? thanks - @gvwilson