-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate HOST, PORT, and PROXY env vars when Dash.run() is invoked #2908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but also need to set the parameters to None
on line 1984-1986
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry we lost the default arguments by setting the parameters to None, they need the previous default instead.
Also need to add a changelog entry then it's good to merge.
dash/dash.py
Outdated
host=None, | ||
port=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
host=None, | |
port=None, | |
host="127.0.0.1", | |
port="8050", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning to ask the same, because they were going to be overwritten anyway, and defaults were already set. Will make the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 💃
Fixes #2902
Made the changes as proposed in #2902. Nothing major, just re-evaluates environment variables when
Dash.run()
is invoked.Contributor Checklist
optionals
CHANGELOG.md