Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3010 Assigning None to exact or shape array properties causes exception #3011

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Fix #3010 Assigning None to exact or shape array properties causes exception #3011

merged 3 commits into from
Sep 20, 2024

Conversation

CNFeffery
Copy link
Contributor

For array-type properties where individual elements are of type exact or shape, and each element accepts component-type sub-properties, assigning None to this array property can lead to an exception error, closes #3010

@CNFeffery
Copy link
Contributor Author

run pytest components\dash-table\tests\selenium\test_basic_operations.py got no error in my local tests:

image

T4rk1n
T4rk1n approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Nice catch. thank you.

@T4rk1n T4rk1n merged commit ef00323 into plotly:dev Sep 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Assigning None to exact or shape array properties causes exception
2 participants
@CNFeffery @T4rk1n