Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jupyterlab v4 in dependency constraints #3028

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

mthiboust
Copy link
Contributor

@mthiboust mthiboust commented Oct 8, 2024

Fixes #2804 and #2998

The current dash extension for jupyterlab cannot be installed with jupyerlab v4. In practice, it means that the backend is not able to communicate with the juperlab frontend to retrieve the base URL when using the jupyter_dash.infer_jupyter_proxy_config() method. I made it work by simply changing the dependency constraints and it is now working.

@gvwilson
Copy link
Contributor

gvwilson commented Oct 8, 2024

@marthacryan @T4rk1n does this overlap with ongoing work in Plotly.py / Plotly.js on Jupyter support?

@T4rk1n
Copy link
Contributor

T4rk1n commented Oct 8, 2024

@gvwilson No, this is for fixing infer_jupyter_proxy_config for hosted jupyter notebooks.

@mthiboust Look like there is some conflict with the new version and typescript, try updating typescript in the devDependencies.

@mthiboust
Copy link
Contributor Author

mthiboust commented Oct 8, 2024

@mthiboust Look like there is some conflict with the new version and typescript, try updating typescript in the devDependencies.

@T4rk1n Should be ok now

Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good thank you.

@T4rk1n T4rk1n merged commit f2244d6 into plotly:dev Oct 9, 2024
3 checks passed
@T4rk1n T4rk1n mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The infer_jupyter_proxy_config method does not work due to timeout
4 participants