Updates to Contributing Checklists #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
approved these changes
Oct 18, 2018
CONTRIBUTING.md
Outdated
| @@ -66,6 +67,8 @@ _For larger features, your contribution will have a higher likelihood of getting | |||
|
|
|||
| ### Post-Merge checklist | |||
| - [ ] You have tagged the release using `git tag v<version_number>`. | |||
| - [ ] You have pushed this tag using `git push <tag_name>` | |||
There was a problem hiding this comment.
This push to origin, only contributors can push to origin. So it should state that the merger have to tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the Checklists here #430 and noticed some small areas that can be improved.
Also, I found it really helpful to copy-paste the checklist and click the checkboxes as I went down the list. I put a small note to encourage new contributors to do the same.