Percy runner #923
Merged
Percy runner #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isk miss that from some weird percy auto merge
dash/testing/browser.py
Outdated
| @@ -456,6 +456,9 @@ def visit_and_snapshot(self, resource_path, hook_id): | |||
| self.driver.get(self.server_url + resource_path) | |||
| self.wait_for_element_by_id(hook_id) | |||
| self.percy_snapshot(resource_path) | |||
| assert not self.driver.find_elements_by_css_selector( | |||
| "div.dash-debug-alert" | |||
| ), "devtools should not raise an error alert" | |||
There was a problem hiding this comment.
though, might need an option to disable this in case someone wants to snapshot the errors
There was a problem hiding this comment.
🎉 works like a charm
added 2 commits
September 13, 2019 23:28
alexcjohnson
approved these changes
Sep 14, 2019
There was a problem hiding this comment.
Your call if slash-flexibility #923 (comment) is important. Aside from that question this looks great. 💃
Make sure to go back and remove the ref to this branch from dash-docs after this is released.
added 2 commits
September 14, 2019 17:08
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
…down-#808 sets autoComplete to off in Dropdown plotly#808
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
sets autoComplete to off in Dropdown #808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.