Ddk eager flag fix #985
Closed
Ddk eager flag fix #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 27, 2019 16:42
# Conflicts: # dash-renderer/package-lock.json
# Conflicts: # dash-renderer/package-lock.json
dash/dash.py
Outdated
|
|
||
| # static files from the packages | ||
| self.css = Css(self.css.config.serve_locally) | ||
| self.scripts = Scripts(self.scripts.config.serve_locally, eager_loading) |
There was a problem hiding this comment.
Do we need to recreate these here? Wouldn't it be sufficient to just say
self.scripts.config.eager_loading = eager_loadingor even
for module_name in ComponentRegistry.registry:
module = sys.modules[module_name]
if getattr(module, '_force_eager_loading', False):
self.scripts.config.eager_loading = True
breakThere was a problem hiding this comment.
Ah! I think you're right. I think I misunderstood how/when this got evaluated. But the filter only gets called later.
dash/dash.py
Outdated
| if self.config.include_assets_files: | ||
| self._walk_assets_directory() | ||
|
|
||
| self._validate_layout() | ||
|
|
||
| self._generate_scripts_html() | ||
| self._generate_css_dist_html() |
There was a problem hiding this comment.
Seems like we need these for their side-effects, or perhaps recreating self.scripts and self.css was the problem? Regardless, I don't see any harm bringing this back.
There was a problem hiding this comment.
Agreed. Undoing this.
added 2 commits
October 29, 2019 18:09
|
@alexcjohnson Closing this in favor of #986 as the baseline was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #984 - delays (reevaluates) Css and Scripts at the moment when the server is ready instead of doing so during initialization.
This should allow us to handle both (1) app.run_server and (2) gunicorn / multi-page apps correctly.