Skip to content

Commit

Permalink
Merge pull request #216 from plotly/457-remove-warning
Browse files Browse the repository at this point in the history
Remove no IDs warning
  • Loading branch information
HammadTheOne authored Jul 16, 2020
2 parents eb44067 + d874e85 commit c1c51f3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
All notable changes to `dash` will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## [0.6.4] - 2020-07-14
**Changed**
- Removes warning message when an app is launched without any component ID's present in the layout. When writing callbacks it iss natural to assume that an ID is necessary, and this warning may be misleading for apps without callbacks (for more details, see [#216](https://github.com/plotly/dashR/pull/216).


## [0.6.3] - 2020-06-25
**Changed**
- `dash-renderer` updated to v1.5.1
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: dash
Title: An Interface to the Dash Ecosystem for Authoring Reactive Web Applications
Version: 0.6.3
Version: 0.6.4
Authors@R: c(person("Chris", "Parmer", role = c("aut"), email = "chris@plotly.com"), person("Ryan Patrick", "Kyle", role = c("aut", "cre"), comment = c(ORCID = "0000-0001-5829-9867"), email = "ryan@plotly.com"), person("Carson", "Sievert", role = c("aut"), comment = c(ORCID = "0000-0002-4958-2844")), person("Hammad", "Khan", role = c("aut"), email = "hammadkhan@plotly.com"), person(family = "Plotly Technologies", role = "cph"))
Description: A framework for building analytical web applications, Dash offers a pleasant and productive development experience. No JavaScript required.
Depends:
Expand Down
8 changes: 1 addition & 7 deletions R/dash.R
Original file line number Diff line number Diff line change
Expand Up @@ -1226,13 +1226,7 @@ Dash <- R6::R6Class(

# verify that layout ids are unique
idx <- grep("props\\.id$", layout_nms)
if (!length(idx)) {
warning(
"No ids were found in the layout. ",
"Component ids are critical for targeting callbacks in your application",
call. = FALSE
)
}

layout_ids <- as.character(layout_flat[idx])
duped <- anyDuplicated(layout_ids) > 0

Expand Down

0 comments on commit c1c51f3

Please sign in to comment.