Dash for R v0.3.0 #175
Dash for R v0.3.0 #175
Conversation
* rename pruned_errors to prune_errors * rename pruned to prune * provide support for no_update in Dash for R (#111)
* rename pruned_errors to prune_errors * rename pruned to prune * 🔨 handle stop errors * 🚨 add test for stop errors
* Add line number context to stack traces when srcrefs are available (#133) * ✨ Support line #s when in debug mode * ✨ Add use_viewer option for RStudio * 🚨 Add soft and hard hot reloading tests
add always
* ✨ initial support for meta tags * support arbitrary tags * 🚨 add tests * 🔬 add asserts * add reference to meta tag PR * ⏩ indent meta tags
* add eager_loading parameter * 📛 add buildFingerprint * 📛 add checkFingerprint * use getDependencyPath, + 🐾/Etag support * updates to support async * ✨ properly support gz compression * 🐛 post-async fixes for CSS handling
…races (#137) * 🚚 upgrade dash-renderer to v1.2.2, 🔨 fix stack traces * 🚚 add polyfill.js
* refactor resolvePrefix * camel case resolve_prefix * Update R/utils.R Co-authored-by: HammadTheOne <30986043+HammadTheOne@users.noreply.github.com>
* Added `get_relative_path` and `strip_relative_path` functions. * Added description and examples for method usage.
rpkyle
added
high priority
parity
| - Application titles may be set using the `app$title()` method, for parity with Dash for Python's `app.title` syntax [#168](https://github.com/plotly/dashR/pull/168) | ||
|
|
||
| ### Changed | ||
| - Dash for R now requires `dashCoreComponents` v1.8.0 |
There was a problem hiding this comment.
The table version bump should also be mentioned.
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
| - Dash for R now requires `dashCoreComponents` v1.8.0 | ||
| - Rename `DASH_HOST` to `HOST` and `DASH_PORT` to `PORT` [#167](https://github.com/plotly/dashR/pull/167) |
There was a problem hiding this comment.
This goes beyond the scope of ### Changed and could be ### Deprecated (or removed)+### Added entries instead. Same for DASH_APP_NAME below. As this is a 0.x release it's not technically 100% necessary. At your discretion.
| @@ -1266,6 +1400,24 @@ Dash <- R6::R6Class( | |||
|
|
|||
| # akin to https://github.com/plotly/dash/blob/d2ebc837/dash/dash.py#L338 | |||
| # note discussion here https://github.com/plotly/dash/blob/d2ebc837/dash/dash.py#L279-L284 | |||
| custom_index = NULL, | |||
There was a problem hiding this comment.
Typo at line 965: dire ctly
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
fixed, fixed, fixed in 49c97da
| @@ -457,22 +457,25 @@ valid_seq <- function(params) { | |||
| } | |||
| } | |||
|
|
|||
| resolve_prefix <- function(prefix, environment_var, base_pathname) { | |||
| resolvePrefix <- function(prefix, environment_var, base_pathname) { | |||
There was a problem hiding this comment.
Just wondering why this function is changed to camelCase when many other functions are snake_case.
There was a problem hiding this comment.
I'm going to open a PR to migrate all functions to camelCase and variables to snake_case, which follows the generally accepted style rules for R. That will likely occur within the next week, prior to CRAN submission.
There was a problem hiding this comment.
cf. https://google.github.io/styleguide/Rguide.html, though they use Pascal case instead of camel case, and maybe we should also. 🤔
There was a problem hiding this comment.
Kk, thx. Pick one, enforce it. Move on :)
📘 🤺Co-Authored-By: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
| <html> | ||
| <head> | ||
| {%meta_tags%} | ||
| <title>Testing Again</title> |
There was a problem hiding this comment.
What happens if you set both app$title and the template? The template wins? Maybe adding some default title app$title("On no! Not again!") in this test makes that behavior more obvious.
There was a problem hiding this comment.
If you set app$title, it wins. I suspect this is what we want, rather than the template taking precedence, though I cannot say for sure.
This PR implements several new features related to the Dash for R v0.3.0 release:
[0.3.0] - 2020-02-12
Added
app$title()method, for parity with Dash for Python'sapp.titlesyntax #168Changed
dashCoreComponentsv1.8.0dashTablev4.6.0DASH_APP_NAMEenvironment variable has been set #165Deprecated
nameparameter, which is now deprecated with a warning, for parity with Dash for Python #168DASH_HOSTandDASH_PORT, Dash for R now respectsHOSTandPORT#167@alexcjohnson