SQLTable: add row filters #393
Conversation
* Replaced `fixed-data-table` with `react-data-grid`. * Enable/Disable row filters by clicking on the header.
* Removed dependency `fixed-data-table`.
|
@n-riesco I'm having trouble running the artifact. Could you share a screencast? |
|
@jackparmer could you describe what the trouble was? was it hard to discover? should I move the message
|
|
Thanks! I think this looks good. |
| @@ -5,6 +5,8 @@ | |||
| <meta charset="utf-8"> | |||
| <title>Falcon SQL Client</title> | |||
|
|
|||
| <link rel="stylesheet" type="text/css" href="static/css/falcon.css"></link> | |||
There was a problem hiding this comment.
Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation
There was a problem hiding this comment.
@n-riesco Looks good as well 💃
There was a problem hiding this comment.
Probably too late to change; however, is there a reason we have separate css files and not using something webpack to bundle this. Again not important just an observation
This is a temporary solution. I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.
There was a problem hiding this comment.
I'd like to come back to packing CSS with webpack and possibly using http://lesscss.org/ to define a some sort of theme to be used by all components.
I've heard good things about Tachyons, which seems to be what SQLPad is using. Should be easy enough to harmonize something like this with plotly's styleguide.
There was a problem hiding this comment.
Jack, as usual, your collections of links are gold! :)
Replaced
fixed-data-tablewithreact-data-gridImplemented row filters
Closes #351
@tarzzz Lately, I've been asking you to review only PRs for the backend. Would you like to review this PR?
@jackparmer Would you take this PR for a spin and see if you'd like to change anything?