This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
routes: set X-Frame-Options: DENY #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mitigation measure against clickjacking.
|
Hi @tarzzz, would be able to have a look at this PR and check if it breaks anything on the onprem side? |
|
Down the line (5 years maybe 😁) the UI may be so complex that iframes are necessary, but for now I do not see any reason not to proceed with the merge. I do not have access to the issue it closes so I'll trust it resolves it. 👍 from me. |
|
Talked to @tarzzz on slack and agreed to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/plotly/streambed/issues/11103
cc/ @tarzzz @scjody @nicolaskruchten @kndungu