move _indicatorLayer in fullLayout._toppaper

plotly · Jun 26, 2019 · 03cb7c3 · etpinard · Jun 27, 2019 · antoinerg
1 parent 95de457
commit 03cb7c3
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 1 deletion.
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -3780,7 +3780,7 @@ function makePlotFramework(gd) {
     fullLayout._sunburstlayer = fullLayout._paper.append('g').classed('sunburstlayer', true);
 
     // single indicator layer for the whole plot
-    fullLayout._indicatorlayer = fullLayout._paper.append('g').classed('indicatorlayer', true);
+    fullLayout._indicatorlayer = fullLayout._toppaper.append('g').classed('indicatorlayer', true);
 
     // fill in image server scrape-svg
     fullLayout._glimages = fullLayout._paper.append('g').classed('glimages', true);

diff --git a/test/image/baselines/indicator_scatter3d.png b/test/image/baselines/indicator_scatter3d.png
diff --git a/test/image/mocks/indicator_scatter3d.json b/test/image/mocks/indicator_scatter3d.json
@@ -0,0 +1,52 @@
+{
+  "data": [{
+    "domain": {
+      "y": [0, 1],
+      "x": [0.25, 0.75]
+    },
+    "title": {"text": "Sensor"},
+    "type": "indicator",
+    "mode": "number+delta",
+    "delta": {"reference": 9},
+    "ticker": {
+      "showticker": true,
+      "showpercentage": true
+    },
+    "value": 10
+  }, {
+    "type": "scatter3d",
+    "name": "Sensor",
+    "z":[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
+    "x":[0, 1, 3, 5, 7, 9, 12, 15, 13, 15],
+    "y":[50, 32, 12, 78, 65, 54, 69, 23, 32, 100],
+    "marker": {
+      "opacity": 1,
+      "color": "rgba(125, 125, 125, 0.1)"
+    }
+  }],
+  "layout": {
+    "width": 400,
+    "height": 300,
+    "scene": {
+      "camera": {
+        "eye": {"x":-1.172852145187388,"y":1.8080244316159928,"z":0.20728121045818126}
+      }
+    },
+    "font": {
+      "color": "white",
+      "family": "Dosis"
+    },
+    "paper_bgcolor": "black",
+    "plot_bgcolor": "black",
+    "margin": {
+      "t": 25,
+      "r": 25,
+      "l": 25,
+      "b": 25
+    },
+    "autosize": true
+  },
+  "config": {
+    "responsive": true
+  }
+}