Merge pull request #4410 from danieljblinick/support-typed-arrays-for…

…-data-transforms-groups adding support for defining groups in data.transforms.groups using ty…
plotly · Dec 9, 2019 · 162afe4 · 162afe4
2 parents 0be6afd + 56c68bd
commit 162afe4
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/src/transforms/groupby.js b/src/transforms/groupby.js
@@ -172,7 +172,7 @@ function transformOne(trace, state) {
     var groups = trace.transforms[transformIndex].groups;
     var originalPointsAccessor = pointsAccessorFunction(trace.transforms, opts);
 
-    if(!(Array.isArray(groups)) || groups.length === 0) {
+    if(!(Lib.isArrayOrTypedArray(groups)) || groups.length === 0) {
         return [trace];
     }
 

diff --git a/test/jasmine/tests/transform_groupby_test.js b/test/jasmine/tests/transform_groupby_test.js
@@ -53,6 +53,20 @@ describe('groupby', function() {
             }]
         }];
 
+        var mockDataWithTypedArrayGroups = [{
+            mode: 'markers',
+            x: [20, 11, 12, 0, 1, 2, 3],
+            y: [1, 2, 3, 2, 5, 2, 0],
+            transforms: [{
+                type: 'groupby',
+                groups: new Uint8Array([2, 1, 2, 2, 2, 1, 1]),
+                styles: [
+                    {target: 1, value: {marker: {color: 'green'}}},
+                    {target: 2, value: {marker: {color: 'black'}}}
+                ]
+            }]
+        }];
+
         afterEach(destroyGraphDiv);
 
         it('Plotly.plot should plot the transform traces', function(done) {
@@ -318,6 +332,22 @@ describe('groupby', function() {
             .catch(failTest)
             .then(done);
         });
+
+        it('Plotly.plot should group points properly using typed array', function(done) {
+            var data = Lib.extendDeep([], mockDataWithTypedArrayGroups);
+
+            var gd = createGraphDiv();
+
+            Plotly.plot(gd, data).then(function() {
+                expect(gd._fullData.length).toEqual(2);
+                expect(gd._fullData[0].x).toEqual([20, 12, 0, 1]);
+                expect(gd._fullData[0].y).toEqual([1, 3, 2, 5]);
+                expect(gd._fullData[1].x).toEqual([11, 2, 3]);
+                expect(gd._fullData[1].y).toEqual([2, 2, 0]);
+            })
+            .catch(failTest)
+            .then(done);
+        });
     });
 
     describe('many-to-many transforms', function() {