Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour negative valued layer is not visible #4415

Closed
poldz123 opened this issue Dec 6, 2019 · 6 comments · Fixed by #4540
Closed

Contour negative valued layer is not visible #4415

poldz123 opened this issue Dec 6, 2019 · 6 comments · Fixed by #4540
Labels
bug something broken
Milestone

Comments

@poldz123
Copy link

poldz123 commented Dec 6, 2019

Negative numbers within the layer are not that visible, it looks like the symbol it is part of the line.

Adding extra padding should fix this visibility issue only for negative symbols.

contour-sample

@etpinard
Copy link
Contributor

etpinard commented Dec 9, 2019

Thanks for pointing this out.

Maybe instead of some vertical adjustment, we could implement #1597 to make the minus sign more visible.

@etpinard
Copy link
Contributor

etpinard commented Dec 9, 2019

Adding extra padding should fix this visibility issue only for negative symbols.

Oh you mean some padding between the negative sign and the start of the contour line i.e. tweaking the label bounding box dimensions to "pad" the text of the contour labels. That's actually a great idea with or without #1597 and is probably much easier to implement. Calling this a bug.

Thanks for posting @poldz123 !

@etpinard etpinard added the bug something broken label Dec 9, 2019
@alexcjohnson
Copy link
Collaborator

BTW whenever this gets addressed, looks like contour labels sometimes use the regular hyphen "-", not minus sign "−" like we do for all other negatives

MINUS_SIGN: '\u2212'

Looking at https://rreusser.github.io/plotly-mock-viewer/#contour_edge_cases - perhaps when contours.labelformat is specified we don't fix this character, but we do when auto-formatting? Compare the "-1.0e-6" to "−1µ"
Screen Shot 2019-12-09 at 12 03 11 PM

@poldz123 does your example use contours.labelformat? Or is there another case we're missing? We do use the correct minus sign for axis ticks with axis.tickformat, so seems this issue is just with contour labels.

@poldz123
Copy link
Author

poldz123 commented Dec 9, 2019

@alexcjohnson I do use the contours.labelformat with the value: .0f

@etpinard
Copy link
Contributor

@poldz123 I'm attempting to fix this problem in #4540, maybe you could try out this dev bundle:

https://65959-45646037-gh.circle-artifacts.com/0/dist/plotly.min.js

in your use case to see if the results are to your likings. Thanks!

@poldz123
Copy link
Author

poldz123 commented Feb 3, 2020

@etpinard
It looks great, good job. The sign is now visible with the naked eye.

Thanks.

device-2020-02-03-150710

@etpinard etpinard removed their assignment Mar 12, 2020
@archmoj archmoj added this to the v1.53.0 milestone Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants