Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polar.hole #2977

Merged
merged 13 commits into from
Sep 10, 2018
Merged

Add polar.hole #2977

merged 13 commits into from
Sep 10, 2018

Commits on Sep 6, 2018

  1. place <g.barlayer> below <g.scatterlayer> in polar subplot 

    ... just like what Cartesian does
    @etpinard
    etpinard committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    39b2ee3 View commit details
    Browse the repository at this point in the history

  2. add polar.hole 

    - draw subplot with pathAnnulus when polar.hole > 0
- update r range -> x/y range scales
- draw angular grid line from innerRadius w/o translating them
- constrain handles between innerRadius & radius on main drag
- add mock
    @etpinard
    etpinard committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    ea7fd2c View commit details
    Browse the repository at this point in the history

  3. add a few TODO comments related to polar.hole

    @etpinard
    etpinard committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f547692 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. make mock cartesian scale computation marginally simpler

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    35199c6 View commit details
    Browse the repository at this point in the history

  2. cover a few more cases in polar_hole.json

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    8e5833d View commit details
    Browse the repository at this point in the history

  3. add hover tests with polar.hole>0

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    ea877ee View commit details
    Browse the repository at this point in the history

  4. add info about polar.hole in setConvert jsdoc

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    a859872 View commit details
    Browse the repository at this point in the history

  5. modif polar_hole mock to "see" axis line/tick ordering

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    776e292 View commit details
    Browse the repository at this point in the history

  6. draw polar axis ticks above axis lines 

    - this is on-par with how cartesian draw things.
- update baselines
- update layer order jasmine tests now that axis lines are below ticks
    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    9c3dcef View commit details
    Browse the repository at this point in the history

  7. fix and 🔒 maindrag when polar.hole>0

    @etpinard
    etpinard committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    1122907 View commit details
    Browse the repository at this point in the history

  8. add 'inner' radial dragbox when polar.hole>0 

    - which relayouts `radialaxis.range[0]`
- does not try to relayout `radialaxis.angle`
    @etpinard
    etpinard committed Sep 7, 2018
    4 Configuration menu
    Copy the full SHA
    d466146 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2018

  1. Merge branch 'master' into polar-hole

    @etpinard
    etpinard committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    5a998a2 View commit details
    Browse the repository at this point in the history

  2. add 'inner' radial dragbox to all polar subplots 

    so that:
- we don't have to worry about ordering on relayouts
- subplots on non-full-circle sectors can have functioning
  inner radial dragboxes.
    @etpinard
    etpinard committed Sep 10, 2018
    Configuration menu
    Copy the full SHA
    092006a View commit details
    Browse the repository at this point in the history