Scattergl improvements for: fill tozero with bad values fix, fills layering fix, add some line.shape values #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catcup 8 sept
catch up
- when undefined values with option fill tozerox or tozeroy - order of fill scattergl when overlap
still missing spline from scatter
- new test with more overlap with more kind of objects
modified baseline for gl2d_fill_trace_tozero_order / gl2d_scatter_fill_self_next
add somes text traces into the baseline test
…/baselines/gl2d_scatter_fill_self_next.png ) - add a new test with 2 draw side by side
... by using _nexttrace and _prevtrace like SVG scatter does
3 tasks
|
@ErwanMAS great work here. I'm really impressed by the new mocks, especially putting SVG and GL side-by-side, that helps a lot since it's otherwise not always obvious without poring over the data whether the filling & ordering is really supposed to be as it appears in the baseline image or not. @etpinard beautiful simplifications in the last couple of commits. The mocks look fairly complete, so unless my question #3087 (comment) points to some otherwise untested case this should be ready to go! |
|
💯 thank yous to @ErwanMAS , amazing work 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds up on @ErwanMAS's #2979 where
I added a few commits to make his fix more in line with some
scatterlogic.In brief, this PR:
'tozero'with bad (e.g. undefined) valuesline.shapevalues'hv', 'vh', 'hvh', 'vhv'(only missing'spline')Set to be part of
v1.42.0, cc @plotly/plotly_js