Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent vertical modebar from overflowing #3091

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

antoinerg
Copy link
Contributor

This PR makes vertical modebars behave like horizontal ones.

Previously, a vertical modebar could overflow the figure's container:
sharex_2018-10-10_14-06-36

With this PR, it doesn't and wrap the items:
2018-10-10_14-22-36

This patch relies on display:flex which is used on plotly's official webpage and is now very well supported.

@etpinard
Copy link
Contributor

Cool!

Arguably an even better fix would be to collapse the modebar into a

image

menu on small <div>s

@etpinard
Copy link
Contributor

💃

@antoinerg antoinerg merged commit 5c4094f into master Oct 10, 2018
@antoinerg antoinerg deleted the fix-vertical-modebar branch October 10, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants