Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting reversed ranges in 3d scenes (final) #3141

Merged
merged 24 commits into from
Oct 24, 2018

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 23, 2018

This PR is the continuation of PR 3017.
To minimize merge conflicts with master, the latest changes are fetched and already applied in this new branch.
This PR would allow users to display 3D data in plotly.js scenes that may have one or multiple reversed ranges and resolves issue 1940.
The options such as autorange:'reversed' and/or range:[larger, smaller] could be applied in this regard. Most of the fixes to expand this capability are performed at vertex and fragment shaders. And 3 new image tests are added.
@etpinard @alexcjohnson

@etpinard
Copy link
Contributor

This PR is the continuation of PR 3017.

To minimize merge conflicts with master, the latest changes are fetched and already applied in this new branch.

Great. Thanks for opening a new PR. This makes my life much easier.

Can we close #3071 ?

@archmoj
Copy link
Contributor Author

archmoj commented Oct 23, 2018

Yes we could close the other PR. Do you want me to close that?

@etpinard etpinard added status: reviewable bug something broken feature something new labels Oct 24, 2018
@etpinard etpinard added this to the v1.42.0 milestone Oct 24, 2018
package.json Outdated Show resolved Hide resolved
@etpinard
Copy link
Contributor

@archmoj amazing work!

I closed #3071 and made one tiny tiny comment. Once addressed, we'll go ahead and merge this thing.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 24, 2018

Thank you @etpinard & @alexcjohnson for the encouragement and help on this very first PR.
Your idea of using glslify was really helped simplify the code.
I updated the package.json & it looks like there is no additional change appeared in the lock when I used npm i. So this should be ready to merge, I hope.

@alexcjohnson
Copy link
Collaborator

💃 I'll let you do the honors @archmoj

@archmoj archmoj merged commit 581890c into master Oct 24, 2018
@archmoj archmoj deleted the rev-bounds3d_fetched-master branch October 24, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement autorange: "reversed" in 3d
3 participants